Add configurable read/update benchmark with watch support #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add read_update benchmark command for mixed workload testing
wonderyl
reviewed
Aug 15, 2025
wonderyl
reviewed
Aug 15, 2025
| // Start to watch the configmaps | ||
| watches := make([]watch.Interface, 0) | ||
| var wg sync.WaitGroup | ||
| for i := 0; i < total; i++ { |
There was a problem hiding this comment.
Is this supposed to simulate cilium's use case? In Cilium's use case, each pod is watched by each cilium agent, so it creates multiple watch updates for one mutation of a pod.
wonderyl
reviewed
Aug 15, 2025
wonderyl
reviewed
Aug 15, 2025
wonderyl
reviewed
Aug 15, 2025
|
|
||
| return &internaltypes.BenchmarkReport{ | ||
| Description: fmt.Sprintf(` | ||
| Environment: Combine %d read requests and %d update requests during benchmarking. Workload: Deploy %d configmaps in %d KiB`, |
There was a problem hiding this comment.
Do we need to measure anything of the watches?
wonderyl
reviewed
Aug 15, 2025
fuweid
reviewed
Aug 19, 2025
fuweid
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read_update benchmark command for mixed workload testing and implement concurrent watch connections for all generated ConfigMaps.
Load Profile
Includes staleList (read) and Patch (update) operations.
Controlled via the --read-ratio flag to adjust the proportion of read vs. update actions.